Remove name-based command

tjcsl / cslbot

An easily extensible, modular irc bot.

GNU General Public License v2.0

15 stars 16 forks source link

Remove name-based command #849

Closed csssuf closed 9 years ago

csssuf commented 10 years ago

ahamilto
creffett
fwilson
laudiacay
skasturi
sdamashek alias
srepetsk alias

These should not be part of the main bot.

pefoley2 commented 10 years ago

I'd be open to making a local commands dir of some sort, but I'd like to keep them in the main repo. Moving them to an "tjhsst" group might make sense too.

csssuf commented 10 years ago

I strongly feel that they shouldn't be included in the main repo. It's pretty clear there's been some interest in this bot outside of our personal group, and so I think at this point they're inappropriate for the main repo. We could move them to a separate contribs repository or something, though.

an-empty-string commented 10 years ago

I'm in agreement with @csssuf on this. Git submodules would be an ideal solution to this -- however, I'm not sure they'd work with our current structure.

pefoley2 commented 10 years ago

I could probably whip up submodule support once I get time

sckasturi commented 10 years ago

+1 @csssuf. This has been long overdue.

On Mon Nov 03 2014 at 12:56:32 PM Peter Foley notifications@github.com wrote:

I could probably whip up submodule support once I get time

— Reply to this email directly or view it on GitHub https://github.com/tjcsl/cslbot/issues/849#issuecomment-61518972.

pefoley2 commented 10 years ago

So, I've added support for loading commands from an auxiliary subdir. It shouldn't be too hard to expand this to support factoring out more stuff.

pefoley2 commented 9 years ago

All the name-based commands have been moved to https://github.com/tjcsl/cslbot-tjhsst