Update JQuery from 1.12.4 to 3.7.1 and remove references to jquery.cookie

tjcsl / ion

TJ Intranet 3

https://ion.tjhsst.edu

GNU General Public License v2.0

100 stars 91 forks source link

Update JQuery from 1.12.4 to 3.7.1 and remove references to jquery.cookie #1701

Open aarushtools opened 4 months ago

aarushtools commented 4 months ago

Proposed changes

Change all deprecated functions/syntax to its modern equivalent so jquery 3.7.1 can work (i.e. .click() -> .trigger("click"))
Remove references to jquery.cookie (which does not support jquery 3 and was archived in 2017) and instead use js-cookie which is already used in other files such as this one

Brief description of rationale

JQuery 1.12 is EOL, as well as jquery.cookie

coveralls commented 4 months ago

coverage: 79.447% (+0.04%) from 79.412% when pulling be9b840c0b89c823d67a2eacd93d51b393af44d1 on aarushtools:jq-update into 1d1ff53a21f90e2e7acac128d82653af932ed509 on tjcsl:dev.

coveralls commented 4 months ago

coverage: 79.447% (+0.04%) from 79.412% when pulling be9b840c0b89c823d67a2eacd93d51b393af44d1 on aarushtools:jq-update into 1d1ff53a21f90e2e7acac128d82653af932ed509 on tjcsl:dev.

coveralls commented 4 months ago

coverage: 79.452% (-0.02%) from 79.468% when pulling fd2c29f6e99c862929f868819b75fd8ed4e3fb7b on aarushtools:jq-update into f164994ae3be5ae4e619c13fb56e9fe85bb5bd22 on tjcsl:dev.

alanzhu0 commented 3 months ago

Does JQuery require .on("click", ...? I prefer .click(...

aarushtools commented 3 months ago

Does JQuery require .on("click", ...? I prefer .click(...

Yeah .click is deprecated since 3.3 so they could separate out .click() into .trigger("click") and .click(...) to .on("click", ...)

coveralls commented 3 months ago

coverage: 79.341%. remained the same when pulling b32da0305cd64384fef8c972b5c0df79ac9e273f on aarushtools:jq-update into 1888e89126a19fed0c6c48c2fa5acb0cad2307ea on tjcsl:dev.

alanzhu0 commented 1 month ago

Sorry for late review...if you can resolve merge conflicts I'll merge asap