tjcsl / ion

TJ Intranet 3
https://ion.tjhsst.edu
GNU General Public License v2.0
101 stars 90 forks source link

feat: add push notifications #1704

Open aarushtools opened 2 months ago

aarushtools commented 2 months ago

Proposed changes

Brief description of rationale

Many of Ion's current notification features rely on sending emails but people check push notifications more often. This makes the PWA experience more intuitive especially on mobile

Notes

Video of it working on windows Video of it working on iOS

alanzhu0 commented 2 months ago

This is great!!! Are you all done or still working on stuff? One useful notification option to add is when your bus arrives you get sent a notif, and also maybe some text description of where it's parked (e.g. "in front of the curb," "right front row", "left back row"). Maybe those notifs have to be delayed so they aren't sent until the end of the day (4 pm most days, but dynamically calculated for early release). And also maybe a notif that sends at 4 pm "your bus isn't here yet" if it hasn't arrived.

great work!!

aarushtools commented 2 months ago

Everything is done, I'll try adding that feature 👍

aarushtools commented 2 months ago

I added it, here's what it looks like: image and the bus spot id -> string translations: image

coveralls commented 2 months ago

Coverage Status

coverage: 79.119% (-0.2%) from 79.361% when pulling 9ca08509803a54ecbc96704f1690b03b7e41921b on aarushtools:webpush into e5e51f2eaad7aaa10b5aee519038167121fb546a on tjcsl:dev.

alanzhu0 commented 1 month ago
aarushtools commented 1 month ago

@alanzhu0 everythings done 👍

aarushtools commented 1 month ago

Idk why it's failing I ran build_docs like 20 times

aarushtools commented 1 month ago

to test: