tjcsl / ion

TJ Intranet 3
https://ion.tjhsst.edu
GNU General Public License v2.0
100 stars 91 forks source link

feat(meta): add ios pwa loading screen #1716

Closed aarushtools closed 1 month ago

aarushtools commented 2 months ago

Proposed changes

Brief description of rationale

Video of what it looks like

coveralls commented 2 months ago

Coverage Status

coverage: 79.343% (+0.005%) from 79.338% when pulling 779e2f8e054348be9e078ad1d9e62effc515f9c4 on aarushtools:pwa-loadscreen into 8cb77914c830da3b47ff812f46421b526b9fbf76 on tjcsl:dev.

krishnans2006 commented 2 months ago

Looks amazing, great work! Just a quick question (not an official review): where'd you get that list of required resolutions? Feels slightly excessive to me...

alanzhu0 commented 2 months ago

Looks good! Small thing - can you make the ion logo background color match the blue overall loading screen background?

aarushtools commented 2 months ago

Looks amazing, great work! Just a quick question (not an official review): where'd you get that list of required resolutions? Feels slightly excessive to me...

Yeah it is but unfortunately you have to put a link tag for each device on the apple spec. I used pwa-asset-generator and it auto generates most of this. Also, all the tags are abstracted away in a separate file (and images in a separate folder) so 1-2 more lines to support something like the iphone 4 shouldn't really make a difference if we want to match 100% of the apple spec

Looks good! Small thing - can you make the ion logo background color match the blue overall loading screen background?

Sorry I didn't notice, it should be fixed now 👍