Implement individual students stickying

tjcsl / ion

TJ Intranet 3

https://ion.tjhsst.edu

GNU General Public License v2.0

100 stars 91 forks source link

Implement individual students stickying #1723

Closed JasonGrace2282 closed 3 weeks ago

JasonGrace2282 commented 1 month ago

Proposed changes

Allow stickying individual students to a scheduled 8th period.

Brief description of change

Closes #1719

Add a ManyToManyField to User called sticky_students.
There is also a new method called EighthScheduledActivity.is_user_stickied(user) which checks if an individual user is stickied, replacing the old get_sticky method.

You can edit the stickied students at /eighth/admin/scheduling/schedule?activity=<some_activity_pk>

JasonGrace2282 commented 1 month ago

Maybe use JS and only populate the field when the user clicks on it?

I just pushed a commit that populates it as soon as the page has loaded. Could you check if that's fast enough for you?

As for sending an email, I'm not sure how much I would like that as a user - but I could also see it being really helpful for some people. As such, I'm -0 on the idea: if you really think it's useful/important, I can implement it.

alanzhu0 commented 1 month ago

Did you change the name to 'user sticky'? Also yes - email would be helpful if you can add that.

JasonGrace2282 commented 1 month ago

I haven't implemented email yet (if I get a chance later, I can do that), but everything else should be done, namely:

Fixing the bug with ajax
Changing the label to individual sticky

coveralls commented 1 month ago

coverage: 79.118% (+0.02%) from 79.094% when pulling 19ffbfd51d04ac9cff512f93a4a7c0f20dd4e24e on JasonGrace2282:individual-sticky into 129cfbca44500e288b7cdf84f02180b3139378de on tjcsl:dev.