tjcsl / ion

TJ Intranet 3
https://ion.tjhsst.edu
GNU General Public License v2.0
99 stars 91 forks source link

Use bcc in announcement notification emails #305

Closed gengkev closed 8 years ago

gengkev commented 8 years ago

I've signed up to receive emails when a news item is posted, but the emails don't use bcc; in other words, every time an email is sent, I can see the other 16 people who have opted to receive such emails. This isn't a huge privacy concern since these emails are available on Ion anyway, but it might be prudent to use bcc instead regardless.

Relevant files: https://github.com/tjcsl/ion/blob/master/intranet/apps/announcements/notifications.py#L132 https://github.com/tjcsl/ion/blob/master/intranet/apps/notifications/emails.py

jwoglom commented 8 years ago

Good catch. Already fixed, actually, just not pushed to git yet.

On Tue, Nov 17, 2015 at 8:21 PM Kevin Geng notifications@github.com wrote:

I've signed up to receive emails when a news item is posted, but the emails don't use bcc; in other words, every time an email is sent, I can see the other 16 people who have opted to receive such emails. This isn't a huge privacy concern since these emails are available on Ion anyway, but it might be prudent to use bcc instead regardless.

Relevant files:

https://github.com/tjcsl/ion/blob/master/intranet/apps/announcements/notifications.py#L132

https://github.com/tjcsl/ion/blob/master/intranet/apps/notifications/emails.py

— Reply to this email directly or view it on GitHub https://github.com/tjcsl/ion/issues/305.

gengkev commented 8 years ago

alright, thanks for letting me know!

jwoglom commented 8 years ago

Closed as of 00c1855