search

tjcsl / ion

TJ Intranet 3
https://ion.tjhsst.edu
GNU General Public License v2.0
100 stars 89 forks source link

Dark mode is inconsistent in bolding between polls and events #777

Closed theo-o closed 5 years ago

theo-o commented 5 years ago

Steps to reproduce

  1. Make sure there are no upcoming events scheduled
  2. Make sure there are no polls open
  3. Visit https://ion.tjhsst.edu/events in dark mode
  4. Visit https://ion.tjhsst.edu/polls in dark mode
  5. Look at the text There are no events to display at this time. and compare it with the same text in polls

Expected behavior

The text There are no polls to display at this time. is bolded to match the behavior for a similar situation for polls.

Actual behavior

The text is not bolded.

ghost commented 5 years ago

TL;DR: Bolding the text was a deliberate design decision. I probably would have bolded the polls text too if I'd thought about it.

White text on a black background doesn't have quite as great contrast as black text on a white background. To try to compensate in certain cases (here, in the username/password fields on the login screen, or in the search bar), I bolded text to make it stand out. This was supposed to be a feature, not a bug.

I can either 1) un-bold the text if you still don't think it needs to be bolded or 2) bold the polls text for consistency. Which would you prefer?

theo-o commented 5 years ago

I think bolding is a reasonable UI decision, so I am leaning towards consistency.