tjdevries / colorbuddy.nvim

Your color buddy for making cool neovim color schemes
MIT License
666 stars 24 forks source link

guisp is not applied #50

Open deeedob opened 5 months ago

deeedob commented 5 months ago
NVIM v0.11.0-dev-67+g0e9c92a900
Build type: RelWithDebInfo
LuaJIT 2.1.1713773202
Run "nvim -V1 -v" for more info

Hey, found out that guisp is broken / not applied to the hl group. For example. I'll define something like this:

Color.new("blue", "#658594")
Color.new("yellow", "#c4b28a")
Color.new("red", "#c4746e")

Group.new("DiagnosticUnderlineHint", c.none, c.none, s.underline, c.blue)
Group.new("DiagnosticUnderlineInfo", c.none, c.none, s.underline, c.blue)
Group.new("DiagnosticUnderlineWarn", c.none, c.none, s.underline, c.yellow)
Group.new("DiagnosticUnderlineError", c.none, c.none, s.underline, c.red)

however, looking at Telescope highlights for instances show this: DiagnosticUnderlineErrorxxx cterm=underline gui=underline no guisp mentioned there.

Went a step deeper and debug-printed Group:apply:

function Group:apply()
...
  if self.name == "diagnosticunderlineerror" then
    print("name is: ", self.name, " hl: ", vim.inspect(hl))
    print("key: ", vim.inspect(self.style:keys()))
  end

and in-fact, guisp is missing there too!

name is:  diagnosticunderlineerror  hl:  {
  bg = "none",
  fg = "none",
  underline = true
}

Great tool btw! would be very cool to get this sorted :)