search

tjdevries / tree-sitter-lua

Neovim Tree Sitter Lua Grammar & Library
114 stars 10 forks source link

switch to better scanner #48

Closed tjdevries closed 2 years ago

tjdevries commented 2 years ago

fix #17

@Conni2461 I switched to scanner from https://github.com/MunifTanjim/tree-sitter-lua/tree/main/src

(we might want to consider seeing if we can make our names closer to some of what is happening there, and then ours could be drop-in replacement maybe even of this grammr. just a random thought I had).

Good w/ merging? Stopped some weird segfaults from old scanner for me.

Conni2461 commented 2 years ago

CC @tami5 (sqlite.lua) @fdschmidt93 (telescope-file-browser.nvim) @rcarriga (nvim-notify) thats all people i am aware of right now. sorry

scanner.cc is now scanner.c this breaks docgen cis that build the parser, for example the diff to fix it for telescope

diff --git a/.github/workflows/docgen.yml b/.github/workflows/docgen.yml
index 09ab74d..b00bf44 100644
--- a/.github/workflows/docgen.yml
+++ b/.github/workflows/docgen.yml
@@ -39,9 +39,7 @@ jobs:
         run: |
           # We have to build the parser every single time to keep up with parser changes
           cd ~/.local/share/nvim/site/pack/vendor/start/tree-sitter-lua
-          mkdir -p build parser
-          cc -o ./build/parser.so -I./src src/parser.c src/scanner.cc -shared -Os -lstdc++ -fPIC
-          ln -s ../build/parser.so parser/lua.so
+          make dist
           cd -

       - name: Generating docs