search

tjeb / Mailbox-Alert

BSD 3-Clause "New" or "Revised" License
39 stars 13 forks source link

Initial WebExtension conversion step #71

Closed jobisoft closed 1 year ago

jobisoft commented 1 year ago

In order to move this add-on forward, it needs to switch to the WebExtension locale system, otherwise you would not be able to create menu entries in the background using the menus API, since there you cannot access the legacy locale system.

This PR follows the update tutorial posted here 3 years ago: https://github.com/thundernest/addon-developer-support/wiki/Tutorial:-Switch-to-the-WebExtension-i18n-locale-system

After this PR has been merged, you can create menu entries in the context menu of the folder pane and use the notify tools to signal into your legacy code.

This PR also fixes a few things I found while updating the add-on.

I think everything works (in TB 102), but please double-check. :-)

EnigmaPatrick commented 1 year ago

I've had a quick check and it looks like it works in 102, but needs more work for 115 as issue is still present

jobisoft commented 1 year ago

This is not the needed conversion for 115. This is the locale conversion, so you can use the menus API in the background, which you need for the folder pane menu in 115.

Edit: manifest has still "strict_max_version": "102.*"

jobisoft commented 1 year ago

Please see also my response on topicbox: https://thunderbird.topicbox.com/groups/addons/T6d6b03b89517adfd-M563c3c0af9104f767ae918d0

EnigmaPatrick commented 1 year ago

Oh! I misread your post sorry!