search

tjek / tjek-js-sdk

Tjek JavaScript SDK for the browser and Node.js.
18 stars 4 forks source link

Cleanup savings template #260

Closed jrlarano closed 1 week ago

jrlarano commented 2 weeks ago

This is to avoid the {{savings}} template text from showing up in the modal. The reason why there's {{savings}} is because we use this as template text for comment component which will be tranformed by bumblebee into Spar {savingsVal}. However, the squid returns this as it is.

image

mortenbo commented 2 weeks ago

I do not believe the JS SDK should contain business logic like this. This ought to be handled server-side.

jrlarano commented 2 weeks ago

@mortenbo Agree, should this be handled in Squid or BB?

mortenbo commented 2 weeks ago

I'd say BB.

klarstrup commented 1 week ago

Does that mean that this PR is off?

jrlarano commented 1 week ago

Yes. I'm closing this now. 🙂