Closed hmoraes closed 8 years ago
@hmoraes thanks this is great and it's a lot better not having to bring in jQuery. I've added a few comments.
Will merge in a few hours and make a few small tweaks and release a new version.
Thanks!
@hmoraes it's all updated now. The size has gone up a little bit again because I'm including Zepto in the file as Clappr currently doesn't officially export it. I'm going to submit a PR to clappr that does this, and once that's done if merged this will be able to use that and the file size will go down again.
It was good to help rsrsrs
Actually clappr already exports zepto so it's back to a nice 8kB again now :)
I made several changes to the code. The main ones are:
outerWidth()
was used from JQuery, but the diference betweenwidth()
andouterWidth()
in the spotlight was very small. ThenouterWidth()
was changed towidth()
Image()
object instead of adding in the tag_$imageCache
_$spotligth
,_$backdrop
and_$backdropCarousel
before use rather than maintaining the reference_render()
(renamed to_createElements
) and_init()
on MEDIACONTROL_RENDERED event