Closed renovate[bot] closed 2 months ago
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
Package | New capabilities | Transitives | Size | Publisher |
---|---|---|---|---|
npm/rollup@4.22.4 | None | +18 |
41.6 MB | eventualbuddha, lukastaegert, rich_harris, ...2 more |
🚮 Removed packages: npm/rollup@4.21.3
This PR contains the following updates:
4.21.3
->4.22.4
GitHub Vulnerability Alerts
CVE-2024-47068
Summary
A DOM Clobbering vulnerability was discovered in rollup when bundling scripts that use
import.meta.url
or with plugins that emit and reference asset files from code incjs
/umd
/iife
format. The DOM Clobbering gadget can lead to cross-site scripting (XSS) in web pages where scriptless attacker-controlled HTML elements (e.g., animg
tag with an unsanitizedname
attribute) are present.It's worth noting that similar issues in other popular bundlers like Webpack (CVE-2024-43788) have been reported, which might serve as a good reference.
Details
Backgrounds
DOM Clobbering is a type of code-reuse attack where the attacker first embeds a piece of non-script, seemingly benign HTML markups in the webpage (e.g. through a post or comment) and leverages the gadgets (pieces of js code) living in the existing javascript code to transform it into executable code. More for information about DOM Clobbering, here are some references:
[1] https://scnps.co/papers/sp23_domclob.pdf [2] https://research.securitum.com/xss-in-amp4email-dom-clobbering/
Gadget found in
rollup
A DOM Clobbering vulnerability in
rollup
bundled scripts was identified, particularly when the scripts usesimport.meta
and set output in format ofcjs
/umd
/iife
. In such cases,rollup
replaces meta property with the URL retrieved fromdocument.currentScript
.https://github.com/rollup/rollup/blob/b86ffd776cfa906573d36c3f019316d02445d9ef/src/ast/nodes/MetaProperty.ts#L157-L162
https://github.com/rollup/rollup/blob/b86ffd776cfa906573d36c3f019316d02445d9ef/src/ast/nodes/MetaProperty.ts#L180-L185
However, this implementation is vulnerable to a DOM Clobbering attack. The
document.currentScript
lookup can be shadowed by an attacker via the browser's named DOM tree element access mechanism. This manipulation allows an attacker to replace the intended script element with a malicious HTML element. When this happens, thesrc
attribute of the attacker-controlled element (e.g., animg
tag ) is used as the URL for importing scripts, potentially leading to the dynamic loading of scripts from an attacker-controlled server.PoC
Considering a website that contains the following
main.js
script, the devloper decides to use therollup
to bundle up the program:rollup main.js --format cjs --file bundle.js
.The output
bundle.js
is shown in the following code snippet.Adding the
rollup
bundled script,bundle.js
, as part of the web page source code, the page could load theextra.js
file from the attacker's domain,attacker.controlled.server
due to the introduced gadget during bundling. The attacker only needs to insert animg
tag with the name attribute set tocurrentScript
. This can be done through a website's feature that allows users to embed certain script-less HTML (e.g., markdown renderers, web email clients, forums) or via an HTML injection vulnerability in third-party JavaScript loaded on the page.Impact
This vulnerability can result in cross-site scripting (XSS) attacks on websites that include rollup-bundled files (configured with an output format of
cjs
,iife
, orumd
and useimport.meta
) and allow users to inject certain scriptless HTML tags without properly sanitizing thename
orid
attributes.Patch
Patching the following two functions with type checking would be effective mitigations against DOM Clobbering attack.
Release Notes
rollup/rollup (rollup)
### [`v4.22.4`](https://redirect.github.com/rollup/rollup/blob/HEAD/CHANGELOG.md#4224) [Compare Source](https://redirect.github.com/rollup/rollup/compare/v4.22.3...v4.22.4) *2024-09-21* ##### Bug Fixes - Fix a vulnerability in generated code that affects IIFE, UMD and CJS bundles when run in a browser context ([#5671](https://redirect.github.com/rollup/rollup/issues/5671)) ##### Pull Requests - [#5670](https://redirect.github.com/rollup/rollup/pull/5670): refactor: Use object.prototype to check for reserved properties ([@YuHyeonWook](https://redirect.github.com/YuHyeonWook)) - [#5671](https://redirect.github.com/rollup/rollup/pull/5671): Fix DOM Clobbering CVE ([@lukastaegert](https://redirect.github.com/lukastaegert)) ### [`v4.22.3`](https://redirect.github.com/rollup/rollup/blob/HEAD/CHANGELOG.md#4223) [Compare Source](https://redirect.github.com/rollup/rollup/compare/v4.22.2...v4.22.3) *2024-09-21* ##### Bug Fixes - Ensure that mutations in modules without side effects are observed while properly handling transitive dependencies ([#5669](https://redirect.github.com/rollup/rollup/issues/5669)) ##### Pull Requests - [#5669](https://redirect.github.com/rollup/rollup/pull/5669): Ensure impure dependencies of pure modules are added ([@lukastaegert](https://redirect.github.com/lukastaegert)) ### [`v4.22.2`](https://redirect.github.com/rollup/rollup/blob/HEAD/CHANGELOG.md#4222) [Compare Source](https://redirect.github.com/rollup/rollup/compare/v4.22.1...v4.22.2) *2024-09-20* ##### Bug Fixes - Revert fix for side effect free modules until other issues are investigated ([#5667](https://redirect.github.com/rollup/rollup/issues/5667)) ##### Pull Requests - [#5667](https://redirect.github.com/rollup/rollup/pull/5667): Partially revert [#5658](https://redirect.github.com/rollup/rollup/issues/5658) and re-apply [#5644](https://redirect.github.com/rollup/rollup/issues/5644) ([@lukastaegert](https://redirect.github.com/lukastaegert)) ### [`v4.22.1`](https://redirect.github.com/rollup/rollup/blob/HEAD/CHANGELOG.md#4221) [Compare Source](https://redirect.github.com/rollup/rollup/compare/v4.22.0...v4.22.1) *2024-09-20* ##### Bug Fixes - Revert [#5644](https://redirect.github.com/rollup/rollup/issues/5644) "stable chunk hashes" while issues are being investigated ##### Pull Requests - [#5663](https://redirect.github.com/rollup/rollup/pull/5663): chore(deps): update dependency inquirer to v11 ([@renovate](https://redirect.github.com/renovate)\[bot], [@lukastaegert](https://redirect.github.com/lukastaegert)) - [#5664](https://redirect.github.com/rollup/rollup/pull/5664): chore(deps): lock file maintenance minor/patch updates ([@renovate](https://redirect.github.com/renovate)\[bot]) - [#5665](https://redirect.github.com/rollup/rollup/pull/5665): fix: type in CI file ([@YuHyeonWook](https://redirect.github.com/YuHyeonWook)) - [#5666](https://redirect.github.com/rollup/rollup/pull/5666): chore(deps): lock file maintenance minor/patch updates ([@renovate](https://redirect.github.com/renovate)\[bot]) ### [`v4.22.0`](https://redirect.github.com/rollup/rollup/blob/HEAD/CHANGELOG.md#4220) [Compare Source](https://redirect.github.com/rollup/rollup/compare/v4.21.3...v4.22.0) *2024-09-19* ##### Features - Add additional known global values to avoid access side effects ([#5651](https://redirect.github.com/rollup/rollup/issues/5651)) ##### Bug Fixes - Ensure deterministic chunk hash generation despite async renderChunk hook ([#5644](https://redirect.github.com/rollup/rollup/issues/5644)) - Improve side effect detection when using "smallest" treeshaking preset when imports are optimized away ([#5658](https://redirect.github.com/rollup/rollup/issues/5658)) ##### Pull Requests - [#5644](https://redirect.github.com/rollup/rollup/pull/5644): fix: apply final hashes deterministically with stable placeholders set ([@mattkubej](https://redirect.github.com/mattkubej), [@lukastaegert](https://redirect.github.com/lukastaegert)) - [#5646](https://redirect.github.com/rollup/rollup/pull/5646): chore(deps): update dependency [@mermaid-js/mermaid-cli](https://redirect.github.com/mermaid-js/mermaid-cli) to v11 ([@renovate](https://redirect.github.com/renovate)\[bot]) - [#5647](https://redirect.github.com/rollup/rollup/pull/5647): chore(deps): update dependency concurrently to v9 ([@renovate](https://redirect.github.com/renovate)\[bot]) - [#5648](https://redirect.github.com/rollup/rollup/pull/5648): chore(deps): lock file maintenance minor/patch updates ([@renovate](https://redirect.github.com/renovate)\[bot]) - [#5651](https://redirect.github.com/rollup/rollup/pull/5651): feat: add `AggregateError`, `FinalizationRegistry`, `WeakRef` to knownGlobals ([@re-taro](https://redirect.github.com/re-taro)) - [#5653](https://redirect.github.com/rollup/rollup/pull/5653): Fix example selection in REPL ([@lukastaegert](https://redirect.github.com/lukastaegert)) - [#5657](https://redirect.github.com/rollup/rollup/pull/5657): chore(deps): update dependency vite to v5.4.6 \[security] ([@renovate](https://redirect.github.com/renovate)\[bot]) - [#5658](https://redirect.github.com/rollup/rollup/pull/5658): Detect variable reassignments in modules without side effects ([@lukastaegert](https://redirect.github.com/lukastaegert))Configuration
📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.