This improves the scroll animation which occurs after an item has been expanded a lot, imho. Not only it solves #90, but also manage the special case in which the item is taller than the container ListView. In particular, after the item expands, it makes some computation and then:
If the just expanded item is already fully visible, nothing happens.
If it is bigger than the container ListView, it is scrolled so its top bound is on top of the list.
If its top bound is out if the container ListView, it is scrolled so it's on top of the list.
If its bottom bound is out if the container ListView, it is scrolled so it's at bottom of the list.
I made this edit particularly because of case 2: I'm using items that, when expanded, can be really tall. Not sure if other cases were already covered, but I'm quite sure I experienced issues also when items were smaller.
I tested it on the most recent API and on API 8 and 10. It works as expected in all cases. I made the PR on top of your last commit and in a separate brach, so you can merge with no problems.
Further improvement to make it perfect could be starting the scroll animation together with the expand animation (i.e. in the onAnimationStart callback instead of onAnimationEnd). Unfortunately this requires not only to get the end height in advance (from the ExpandCollapseAnimation instance for example), but also to take account of the old expanded item which, in the meantime, could be collapsing. I'll work on it if I'll have some spare time, it's not critical for me atm.
This improves the scroll animation which occurs after an item has been expanded a lot, imho. Not only it solves #90, but also manage the special case in which the item is taller than the container ListView. In particular, after the item expands, it makes some computation and then:
I made this edit particularly because of case 2: I'm using items that, when expanded, can be really tall. Not sure if other cases were already covered, but I'm quite sure I experienced issues also when items were smaller.
I tested it on the most recent API and on API 8 and 10. It works as expected in all cases. I made the PR on top of your last commit and in a separate brach, so you can merge with no problems.
Further improvement to make it perfect could be starting the scroll animation together with the expand animation (i.e. in the
onAnimationStartcallback instead ofonAnimationEnd). Unfortunately this requires not only to get the end height in advance (from theExpandCollapseAnimationinstance for example), but also to take account of the old expanded item which, in the meantime, could be collapsing. I'll work on it if I'll have some spare time, it's not critical for me atm.