[Refactor] Python3 upgrade and Docker containerization

tjfontaine / airprint-generate

Automatically generate AirPrint Avahi service files for CUPS printers

http://www.atxconsulting.com/blog/tjfontaine/2010/11/21/automatically-generate-airprint-avahi-service-files-cups-printers

400 stars 119 forks source link

[Refactor] Python3 upgrade and Docker containerization #24

Closed rchenzheng closed 3 years ago

rchenzheng commented 3 years ago

add support for python3
add interactive generation of avahi service files through docker
convert readme to markdown

No longer will you need to check for dependencies when generating the avahi service file for AirPrint

Thanks @AlexMorro for the issue https://github.com/tjfontaine/airprint-generate/issues/23

Testing methodology

[x] Generate avahi service file
[x] Compare with working file in the live server that was created with python2
[x] Create VM and generate an avahi service file using python2 and compare with python3 generated file
[x] Test print from iPhone

tjfontaine commented 3 years ago

Ok, a couple thoughts:

It would be nice to split out the changes from #23 with @AlexMorro as the author, and @rchenzheng as the committer — just for clean ownership tracking purposes. Then have the Dockerfile addition as its own commit.

Second, I’m quite likely to archive this project after landing this PR, given I don’t maintain any environments that need this functionality — so let me know if you want to maintain your repo and I’ll link to you from the readme.

rchenzheng commented 3 years ago

Ok, a couple thoughts:

It would be nice to split out the changes from #23 with @AlexMorro as the author, and @rchenzheng as the committer — just for clean ownership tracking purposes. Then have the Dockerfile addition as its own commit.

Second, I’m quite likely to archive this project after landing this PR, given I don’t maintain any environments that need this functionality — so let me know if you want to maintain your repo and I’ll link to you from the readme.

I merely took inspiration from it, but credit where credit is due if @AlexMorro wants to create his own PR. I've tested and written the python3 upgrade in docker

I'd be willing to maintain it but I only use it on a hobby scale.

AlexMorro commented 3 years ago

I just changed the imports to work with python 3 and uploaded it if other people had the same issue. I don't have the time and knowledge for maintaining it, at least for now, I don't wan't the credit or anything. @rchenzheng you are welcome for the inspiration, I'm glad.

rchenzheng commented 3 years ago

@tjfontaine Can you review and merge?