search

tjfontaine / node-dns

Replacement dns module in pure javascript for node.js
MIT License
585 stars 154 forks source link

Another implementation of PR #83 and TCP error bug fix #93

Closed rogerc closed 7 years ago

rogerc commented 9 years ago

Redone Pull Request #83 and added error emitter for TCP errors

Moved the truncate test to https://github.com/tjfontaine/native-dns-packet/pull/21

bobvanderlinden commented 9 years ago

Code looks good. I haven't checked the specs of DNS to confirm longName and regexes are correct, but it certainly is a good improvement over #83.

taoeffect commented 8 years ago

This project is no longer maintained, but we are happy to link to a well maintained fork.

Please see: https://github.com/tjfontaine/node-dns/issues/111

tjfontaine commented 7 years ago

Thanks @rogerc I've landed most of these if you still care :)

rogerc commented 7 years ago

Hi @tjfontaine ,

I created a related PR when I created this one too for the native-dns-packet. Did you have a chance to look at that one?

Thanks

Roger