Closed rogerc closed 7 years ago
Code looks good. I haven't checked the specs of DNS to confirm longName and regexes are correct, but it certainly is a good improvement over #83.
This project is no longer maintained, but we are happy to link to a well maintained fork.
Please see: https://github.com/tjfontaine/node-dns/issues/111
Thanks @rogerc I've landed most of these if you still care :)
Hi @tjfontaine ,
I created a related PR when I created this one too for the native-dns-packet. Did you have a chance to look at that one?
Thanks
Roger
Redone Pull Request #83 and added error emitter for TCP errors
Moved the truncate test to https://github.com/tjfontaine/native-dns-packet/pull/21