search

tjgalvin / flint

BSD 3-Clause "New" or "Revised" License
7 stars 1 forks source link

Rename mandatory bandpass calibration argument to optional #122

Closed tjgalvin closed 2 weeks ago

tjgalvin commented 3 weeks ago

Now that casda measurement sets can be used in the continuum imaging pipeline, which do not need to have bandpass solutions applied, it might make sense to make what is currently a mandatory bandpass solutions argument optional. Perhaps --aocalibrate-solutions. This also makes it clear how solutions should be applied, should we start to use other solvers later.

tjgalvin commented 2 weeks ago

I started this in a branch with the intention of adding many new optional arguments, with the intention being that each argument could be used as a way to distinguish what type of solutions there were (e.g. calibrate, hyperdrive etc).

That became way to yuck for my liking. For the moment I think the best path forward will be to just make the current mandatory argument optional with the same name. The code to deduce with measurement set is which should be enough, and until other bandpass solutions are specified keep it simple.

tjgalvin commented 2 weeks ago

Completed and merged in #125