NameError: name 'function' is not defined

tjguk / networkzero

Making it easy for teachers to use simple networking in Python

MIT License

47 stars 14 forks source link

NameError: name 'function' is not defined #6

Closed tomviner closed 8 years ago

tjguk commented 8 years ago

Thanks for taking the trouble, @tomviner. I think you've probably picked up by now that this was fixed in a subsequent commit and is currently correct: https://github.com/tjguk/networkzero/blob/master/networkzero/discovery.py#L68

tomviner commented 8 years ago

no probs @tjguk

while I'm here, I noticed you've added tox to the requirements file, I generated a tox.ini so I can submit that. Also I wondered if travis.ci / appveyor would be handy?

tjguk commented 8 years ago

I added tox (at someone's recommendation) but haven't used it. I currently run 3.4 / 2.7 tests across 4 platforms manually!.

While I'm aware of what they all do, I've never yet used tox.ini / Travis / Appveyor so I'll need some time to pull things together.

Please do feel free to submit whatever you think might be helpful.