tjhladish / AbcSmc

Sequential Monte Carlo Approximate Bayesian Computation with Partial Least Squares parameter estimator
GNU General Public License v3.0
15 stars 7 forks source link

deprecate `AbcSmc::set_sim*` and `AbcSmc::set_executable` in favor of setting from configuration #54

Open pearsonca opened 10 months ago

pearsonca commented 10 months ago

To move AbcSmc toward being a compiled tool, should be marking various methods for deprecation, particularly those that using AbcSmc in compiled-library-with-simulator mode.

The set_sim family are definitely in the category. The key issue for backwards compatibility will be whether the as-a-library mode can correctly find the simulator symbol. That seems immently solvable: have a sensible "just works" default for finding the symbol if its named simulator, has the right signature [plus some useful error messages? convenience checkers?], and maybe allow a configuration option to use a different symbol name is people are picky.