search

tjhorner / upsy-desky

Make your standing desk smarter
https://upsy-desky.tjhorner.dev
Other
478 stars 24 forks source link

ESP32 C3 revision #42

Open phodina opened 6 months ago

phodina commented 6 months ago

Hi @tjhorner,

firstly thanks for the amazing work on the project. I assembled one board and have been using it till now.

I've also been thinking about some additional features and decided to make alternative version:

Any additional ideas what to improve or any comments for the design are welcome.

image

phodina commented 6 months ago

image

phodina commented 6 months ago

Of course there will be need to adjust the firmware for this revision, but that's another topic :-)

tjhorner commented 6 months ago

Wow, this is really great! Nice work. These are some great extra features to have; I especially like the LED terminal connector. I have a light strip on the back of my desk (currently using a cheap Zigbee controller for that) and I imagine many others do, so that's a great addition. And the distance sensor would be great for desks whose protocol haven't been reverse engineered yet (and for those who just want a more precise reading anyway).

I'm currently on vacation but once I get back home I'll review the design in more detail.

This rocks, thanks for sharing :)

phodina commented 6 months ago

These are just small tweaks on top of a very cool project :)

Enjoy your vacation in the meantime!

And be aware that the current footprint for the ToF has small issue https://gitlab.com/kicad/libraries/kicad-symbols/-/merge_requests/4156 that will be resolved hopefully soon.

phodina commented 6 months ago

image

image

To access the debug UART on the SBU pins similar board is needed. https://gitlab.com/phodina/giraffe

tjhorner commented 6 months ago

I took a quick look at the design and it looks great to me so far. I made some changes to the edge cut layer in order to make the DRC happy (it wasn't a fully closed shape). There are also lots of errors in DRC about clearance but I haven't set those up to my preferred fab's capabilities yet, so I'm not too worried about that.

Once I verify the clearances are good enough I can order some prototypes if you think it's ready to test.

Also, it would be great if I could add this to my Tindie store but since you have clearly put a lot of effort into your improvements I want to make sure it's fair to you. You can reach out to me at tj@tjtjtj.tj or on Discord (@tjhorner) and we can work something out!

phodina commented 6 months ago

Thanks for the review. Yeah have not put much effort into the DRC clearance issues as that will be sorted out when the right fabrication technology is chosen.

The only issue I noted are the two connectors as they have holes at the edge of the board. Would that be a problem? Should they be moved back a little bit?

Sure, there's still the task to port the software once the board is manufactured :-)

TheBlackMini commented 1 month ago

Hey, had any progress with this revision? I'm looking at making a couple for myself and was wondering if it would be a good idea to use this one or the original. I like the ideas on this board!

TheBlackMini commented 1 month ago

Not sure if this helps but I've updated the BOM for the part numbers using PCBWay as the reference. https://github.com/phodina/upsy-desky/compare/esp32-c3...TheBlackMini:upsy-desky:esp32-c3

Let me know if you'd like a pull request for it.

Also, I'm not 100% sure on R1 & R2 as the part number for it was for 5.1Ω and not 5.1kΩ as in the schematic on both the ESP datasheet and yours??

phodina commented 2 days ago

Hi @TheBlackMini , yes I plan to manufacture them during July.

Haven't looked atm on the BOM. It will probably be incompatible with the v1. Will check the BOM. Thanks!