search

tjhowse / modbus4mqtt

Modbus TCP <-> MQTT glue. YAML configuration. Robust.
Other
78 stars 34 forks source link

add example config file for sungrow SG5K-D inverter #20

Closed jmkelly closed 3 years ago

jmkelly commented 3 years ago

Hey Travis (and others)

I've been watching https://github.com/tjhowse/modbus4mqtt/issues/16 closely and finally found some time to jump in and test out your library with our Sungrow SG5K-D inverter. I looked at a lot of options for connecting our inverter up to home assistant, and from reading, this seemed like the most active place for our particular inverter / issues. Many thanks must go to all involved, without all the details, I wouldn't have known where to start.

I am seeing some exceptions thrown on some registers some of the time, but generally the 5016 and 5030 ones are the ones that consistently update, which kind of makes sense to me, as these the ones that change most regularly. I pushed out the polling rate to see how that affects it, and without proof, it feels like there are less exceptions. I also found that setting the scan_batching to 1 helped get more registers to report values, but again, no firm proof.

My PR extends on the zip file that was uploaded to the above issue, and added some more registers that I had worked out myself from the documentation.

Just a FYI, I was having issues just prior to xmas with iSolarCloud but I could still read off the inverter with your code, exactly the opposite from what others were reporting....but it seems to have stabilised today, and I've had no trouble reading both.

codecov[bot] commented 3 years ago

Codecov Report

Merging #20 (7ca0510) into master (cf2d700) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #20   +/-   ##
=======================================
  Coverage   95.56%   95.56%           
=======================================
  Files           6        6           
  Lines         676      676           
=======================================
  Hits          646      646           
  Misses         30       30

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cf2d700...7ca0510. Read the comment docs.

tjhowse commented 3 years ago

Awesome! Thanks very much!