tjhowse / modbus4mqtt

Modbus TCP <-> MQTT glue. YAML configuration. Robust.
Other
75 stars 33 forks source link

Home Assistant compatibility #36

Open highground88 opened 2 years ago

highground88 commented 2 years ago

Any chance this can be modified to be a valid Home Assistant repository (Or HAC)?

e.g: https://github.com/ttvt/ModbusTCP2MQTT

tjhowse commented 2 years ago

Sounds quite doable. I'm adding this link here for my own reference for the requirements for a repo to work via HACS: https://hacs.xyz/docs/publish/start

tjhowse commented 2 years ago

@highground88 Are you able to check whether this repo functions with HACS now? I've added the relevant metadata. I'd test it myself but I have a self-hosted HASS install that hasn't been updated in a while, so I don't think it plays nicely with HACS.

tjhowse commented 2 years ago

Hm, it looks like the best fit would be an "add-on" for HASS, as opposed to an integration or plugin: https://developers.home-assistant.io/docs/add-ons/

highground88 commented 2 years ago

Hm, it looks like the best fit would be an "add-on" for HASS, as opposed to an integration or plugin: https://developers.home-assistant.io/docs/add-ons/

Happy to test - I'm currently using "https://github.com/TenySmart/ModbusTCP2MQTT" as an integration through Supervisor custom repo which seems to be working mostly ok. This is fine - but it would be better if everyone could install an add-on by searching for modbus / sungrow etc, without needing to search for and find the github repo manually.

highground88 commented 2 years ago

Sorry looks like some incompatibility still? Thanks for your efforts

HA custom image

HACS custom image

tjhowse commented 2 years ago

That's awesome, thanks! I'll do a bit more digging into what's involved in making it compatible as an add-on.

Sjeiz commented 1 year ago

Any progress?