search

tjhowse / modbus4mqtt

Modbus TCP <-> MQTT glue. YAML configuration. Robust.
Other
81 stars 35 forks source link

Bump the required version of Sungrow-Modbus to include PyCrypto repla… #38

Closed tjhowse closed 3 years ago

tjhowse commented 3 years ago

…cement.

This is blocked on: https://github.com/rpvelloso/Sungrow-Modbus/pull/7

This is a fix for #37

pep8speaks commented 3 years ago

Hello @tjhowse! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2021-10-15 23:56:13 UTC
codecov[bot] commented 3 years ago

Codecov Report

Merging #38 (448672c) into master (96da28f) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #38   +/-   ##
=======================================
  Coverage   95.83%   95.83%           
=======================================
  Files           6        6           
  Lines         841      841           
=======================================
  Hits          806      806           
  Misses         35       35
Impacted Files Coverage Δ
setup.py 0.00% <ø> (ø)
modbus4mqtt/version.py 100.00% <100.00%> (ø)
tests/test_mqtt.py 97.40% <0.00%> (-1.16%) :arrow_down:
tests/test_modbus.py 97.14% <0.00%> (+2.28%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 96da28f...448672c. Read the comment docs.