search

tjhowse / modbus4mqtt

Modbus TCP <-> MQTT glue. YAML configuration. Robust.
Other
78 stars 34 forks source link

Allow configuration of modbus device address ("unit") and used write command #50

Closed M4GNV5 closed 8 months ago

M4GNV5 commented 8 months ago

I got some more time to play around with my RS485-TCP adapter and made it successfully talk to my heatpump. I had to make some further adjustments to this program in order to be able to make it work:

EDIT: I will have a look at the pep8 and coverage comments and try to fix them.

pep8speaks commented 8 months ago

Hello @M4GNV5! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2024-01-15 09:25:01 UTC
codecov[bot] commented 8 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (c02482f) 96.56% compared to head (a8d32cb) 96.53%.

Files Patch % Lines
modbus4mqtt/modbus4mqtt.py 75.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #50 +/- ## ========================================== - Coverage 96.56% 96.53% -0.03% ========================================== Files 6 6 Lines 1047 1068 +21 ========================================== + Hits 1011 1031 +20 - Misses 36 37 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

M4GNV5 commented 8 months ago

The @codecov report seems outdated, but from my perspective this PR should now be ready for review / merge @tjhowse

tjhowse commented 8 months ago

Looks good to me! Amazing work! Thank you very much.