tjibbevanderlaan / chromeos-filesystem-sftp

ChromeOS app to access SFTP server

https://chrome.google.com/webstore/detail/shared-network-folder-sft/gbheifiifcfekkamhepkeogobihicgmn

BSD 3-Clause "New" or "Revised" License

82 stars 21 forks source link

Fix an issue at password mismatch. #137

Closed yoichiro closed 5 years ago

yoichiro commented 5 years ago

Abstract

Fix an issue (an error message not displayed) at a password mismatch.

Expected Behavior

An error message is displayed at filling in a wrong password and trying a mount.

Actual Behavior

The error message is not displayed, and the UI is hanged.

Reason

There are some lines to call the new function handleResultCode to check an error code from the NaCl layer. In one line of them, the passed arguments are wrong. For instance, I forgot to pass the fileSystemId argument...

yoichiro commented 5 years ago

@tjibbevanderlaan Could you review this pull request?

tjibbevanderlaan commented 5 years ago

Thanks!

yoichiro commented 5 years ago

@tjibbevanderlaan Thank you for reviewing and merging!