search

tjibbevanderlaan / chromeos-filesystem-sftp

ChromeOS app to access SFTP server
https://chrome.google.com/webstore/detail/shared-network-folder-sft/gbheifiifcfekkamhepkeogobihicgmn
BSD 3-Clause "New" or "Revised" License
82 stars 21 forks source link

Fix kex methods #150

Open danhunsaker opened 3 years ago

danhunsaker commented 3 years ago

Once a collection of four commits made on GitHub proper, and now a squashed commit of all four. The original commit comments are below.

  • Update sftp_thread.cc

Set our preferred keys to the default OpenSSH list. Because libssh2 is somewhat outdated in this category, it will only support diffie-hellman-group-exchange-sha256 for the moment, but this should help fix errors like #131. Still some more changes to make before this can be PR'd, but should be a lot closer. I hope.

  • Update English messages

Dutch is next!

  • Bijgewerkte Nederlandse berichten

Hoewel ik Google Translate heb gebruikt...

(For you English folk, that's an update to the Dutch messages, as promised in the previous commit.)

  • Update sftp_thread.h

Gotta declare the method before we can define it.

By these commits combined, we should have universal compatibility with OpenSSH servers - as soon as libssh2 adds the additional methods, that is. Anything more extensive may require switching to OpenSSH in the webports instead of libssh2.

stretch07 commented 2 years ago

151

danhunsaker commented 2 years ago

Yeah, I'd noticed. Still worth the effort to try.

At some point when i have more time, i plan to do a version that uses the newer (oddly) libssh instead of libssh2. Until then, though... Not a working fork yet.