tjibbevanderlaan / chromeos-filesystem-sftp

ChromeOS app to access SFTP server
https://chrome.google.com/webstore/detail/shared-network-folder-sft/gbheifiifcfekkamhepkeogobihicgmn
BSD 3-Clause "New" or "Revised" License
82 stars 21 forks source link

Copy hangs on git repos #65

Closed gsf closed 9 years ago

gsf commented 9 years ago

When copying from a remote machine to local, if the directory has a .git subdirectory it hangs on copy. Eventually, I get a notification that the copy operation failed.

screenshot 2015-04-02 at 10 59 13

yoichiro commented 9 years ago

@gsf Thank you for the reporting. Hmm... After occuring the error, was the sftp remote directory unmounted? It seems that the capture image has only two directories: Google Drive and Downloads...

gsf commented 9 years ago

Sorry, the screenshot could have been clearer. The remote directory is not unmounted by the error. See the shots below for the sequence of error messages I receive -- I continue to get the SFTP-9 11 notifications with no progress in the copy until I unmount the remote directory. Note also that the directory I am copying only has a few files in it so its size should not be a factor.

screenshot 2015-04-04 at 16 03 23 screenshot 2015-04-04 at 16 04 20 screenshot 2015-04-04 at 16 05 18

gsf commented 9 years ago

And just as I left that comment, this time it eventually unmounted itself.

gsf commented 9 years ago

Now it either responds with an error or crashes NaCl and unmounts with each attempt. Screenshots with output in background context:

screenshot 2015-04-04 at 16 25 05

screenshot 2015-04-04 at 16 27 48

yoichiro commented 9 years ago

@gsf Thanks a lot. I intend to check the code... Probably, it will be necessary a few weeks until finding the cause...

gsf commented 9 years ago

You've probably already guessed as much but it looks like the large number of directories for git objects is tripping up sftpfs.

yoichiro commented 9 years ago

@gsf In the latest version 1.7.3, the way of fetching the metadata for each file was changed from sync to async. Probably, I guess that the previous way (sync) was heavy logic against memory... Do you have some error continuously using the 1.7.3?

gsf commented 9 years ago

Directory copied successfully! Note that on larger, or even medium-sized projects the copy is taking a long time (~10 minutes), but that's a more general performance issue. This one looks to be fixed. Thanks!

yoichiro commented 9 years ago

@gsf It's a good news. Thank you for the reporting! Feel free to let me know if you find other issue.