tjikko-studio / components

Component library for Tjikko Studio apps
0 stars 0 forks source link

Create components for form fields #1

Closed miherb closed 3 years ago

miherb commented 3 years ago

1- Review the previous components for Form fields that are already developed 2- Add what it is missing to be completed with all states (Empty, Hover, Focus, Filled, Error, Validating, Success and Empty Disabled) 3- Add to Storybook.

Screen Shot 2021-07-03 at 11 52 41 AM

It's here in the design file.

Done Light mode

  • [x] Input
  • [x] Text Area
  • [x] Search bar

Dark mode

  • [x] Input
  • [x] Text Area
  • [x] Search bar

///////////////////////////////////

Backburner (Not a priority right now)

Light mode

Dark mode

highshot-rk commented 3 years ago

Ok, No problem.

miherb commented 3 years ago

Part 1 done. To reopen after if needed.

ktryndchrs commented 3 years ago

@highshot-rk

Here is my review:

I. The font (Inter)

It does not work here on Safari & Firefox

  1. We should use the variable font version here is a file accordingly: inter.woff2.zip

  2. And here is the css I use to the variable version of Inter on another project (as an example)

    @font-face {
    font-family: 'Inter';
    src: url('/path_to_the_font/inter.woff2') format('woff2');
    font-weight: 100 900;  /* To define the variable weight  */
    font-style: oblique 0deg 12deg;   /* To define the variable italic */
    font-display: fallback;
    }

II. Inputs

The background is missing ( bg-gray-50 ). Which cause a weird gray background color on the disabled state.

III. Colors

The gray colour is a custom one

image
gray: {
  50: '#fafbfb',
  100: '#f3f4f6',
  200: '#e5e7eb',
  300: '#d1d5db',
  400: '#9ca3af',
  500: '#6b7280',
  600: '#4b5563',
  700: '#313b4a',
  800: '#222735',
  900: '#171a22'
}

As an extra, here is the brand colour style:

brand: {
  50: '#f3fcfe',
  100: '#e4f8fc',
  200: '#bdeff9',
  300: '#9ee9f5',
  400: '#6ad8e9',
  500: '#17c0d9',
  600: '#1196AE',
  700: '#0B6A7D',
  800: '#023846',
  900: '#022631'
}

Great job so far!