search

tjikko-studio / components

Component library for Tjikko Studio apps
0 stars 0 forks source link

Can this be CSS? #113

Open shawninder opened 3 years ago

shawninder commented 3 years ago

https://github.com/tjikko-studio/components/blob/c57ec908ebb5a53b0787c84a5e065d891d560ccc/src/blocks/Breadcrumb.tsx#L55

@ktryndchrs any reason we're not just using the typical CSS thing here instead, like this for example: https://codepen.io/shawninder/pen/ExXYmMv?editors=1100 ?

ktryndchrs commented 3 years ago

In therm of semantic, this is way better; I initially wanted to update this piece of code by Sagar, but my mind went into another task and I forgot about it

shawninder commented 3 years ago

Which option are you saying is better semantically? The CSS option or the notLast && separator option?

ktryndchrs commented 3 years ago

Definitely the CSS option. I will do it

ktryndchrs commented 3 years ago

Update: A similar solution was used in the footer. I will apply it here