tjikko-studio / components

Component library for Tjikko Studio apps
0 stars 0 forks source link

Add the possibility to add classes to the top parent html wrapper of the components #179

Closed ktryndchrs closed 3 years ago

ktryndchrs commented 3 years ago

So we can for exemple – Have sticky nav – This layout: https://jmp.sh/IgBvuja – etc.

💁‍♀️ This can be done be either @shawninder or @philipdokic

Attachment 1/3 : Here is a video of the issue

https://user-images.githubusercontent.com/416462/136582946-87ff0a64-0c59-407c-a0ad-e77d00b732d8.mp4

Attachment 2/3 : What we want to achieve here:

Screen Shot 2021-10-08 at 11 17 43 AM

Attachment 3/3 : Ideally, we would avoid these two level nested divs

Screen Shot 2021-10-08 at 11 20 01 AM

shawninder commented 3 years ago

Looks like a z-index issue, probably complicated by weird stacking contexts

ktryndchrs commented 3 years ago

Exactly, the z index need to be placed on the root div of the component in the page, but I don't know how to do this 🤷‍♀️

It would be also useful to be able to add custom classes to the root div, so we could (as exemple) also add a sticky property to make the nav stay there when we scroll.

ktryndchrs commented 3 years ago

After a second thought, it would be great to have a way to add classes to the root wrapper directly from the CMS

miherb commented 3 years ago

@ktryndchrs Is it the same issue that we see with the Footer?

In panel:

Screen Shot 2021-10-08 at 10 41 13 AM

In production:

Screen Shot 2021-10-08 at 10 37 51 AM
ktryndchrs commented 3 years ago

Ce problème d'espace blanc en dessous du footer ne semble être qu'en prod @miherb cc:@shawninder