search

tjikko-studio / components

Component library for Tjikko Studio apps
0 stars 0 forks source link

External links open in target #223

Closed ktryndchrs closed 3 years ago

ktryndchrs commented 3 years ago

Related to this ussue External links doesn't open a new tab. This is not a good practice as we want the visitors to stay on the customer's website. #108

ktryndchrs commented 3 years ago

@shawninder As an answer to all the comments above:

Popup (horrible label) is what is being used by that link-field plugin and uses a boolean value. What we can do are the following:

  1. Change the label in the panel to make it more clear for the user to something like "Open in another tab"
  2. Change the name of the property key sent from Kirby in the link object from "popup" to something like "blank"
shawninder commented 3 years ago
  1. Change the label in the panel to make it more clear for the user to something like "Open in another tab"

This is fine, as long as it's intuitive for the end-user that's the objective for now. Making the devs happy will never happen with Kirby