tjikko-studio / components

Component library for Tjikko Studio apps
0 stars 0 forks source link

Let's remove Bold from all default headers in all the blocks #263

Closed miherb closed 2 years ago

miherb commented 2 years ago

Until we can find a better way to manage that and offer that flexibility.

miherb commented 2 years ago

Good job on the writer everywhere @shawninder! I think we can close this.

shawninder commented 2 years ago

Yes although this might need to be tested to make sure not only that it works, but that the font-weight we have chosen to represent boldness in the various blocks is as desired. As of now, some places have regular test at weight 500 and bold at 600 while other place use a regular text font weight of 400 and bold 700... Not to mention any bugs that I have missed (in addition to the bugs I'm aware of, like the lists not working despite the setting being therein Kirby

miherb commented 2 years ago

Ok I'll make a review of all the writer features on all the text content of each blocks.

shawninder commented 2 years ago

Indeed, this seems to have broken everything everywhere, with texts disappearing for no reason, although everything works just fine locally…

shawninder commented 2 years ago

Bold is now optional and makes a difference everywhere tested, but there is still the issue of there being different default font weights representing boldness in different situations. Let's stay alert to that kind of remark, and where there are "complaints" check what the font is, the font weight and the font size.

miherb commented 2 years ago

Yeah, my biggest issues is that it should be a designer's call. We can't just make a call and expect it to look nice everywhere...