search

tjikko-studio / components

Component library for Tjikko Studio apps
0 stars 0 forks source link

Merge : Default and Width Control #64

Open shawninder opened 3 years ago

shawninder commented 3 years ago

There doesn't seem to be any difference between the Default and Width Control versions of the Primary and Secondary blocks when I try them out in StoryBook. Am I missing something?

ktryndchrs commented 3 years ago

@shawninder à It is a classname control that sagar added, but I think it could only be one story (I will; merge them)

Default: default

Width Control with control

shawninder commented 3 years ago

Faudrait que le width control soit pris en main par le component, pas par le story associé… Non?

ktryndchrs commented 3 years ago

Exact en effet

shawninder commented 3 years ago

ok so I still don't really know what WidthControl does, I think we should take that out unless it's clear to anyone. @ktryndchrs maybe?

ktryndchrs commented 3 years ago

Je penses pas que ce soit utile du tout ce truc de "with control"

shawninder commented 3 years ago

OK, let's take this Width control stuff out then.