No more SVGs in tsx format

tjikko-studio / components

Component library for Tjikko Studio apps

0 stars 0 forks source link

No more SVGs in tsx format #75

Closed ktryndchrs closed 3 years ago

ktryndchrs commented 3 years ago

Removed tsx icons
Added the whole remixicon library
Added svgr/webpack to embed inlined svg
Modified the components that required svg in tsx format

shawninder commented 3 years ago

Do we really need to copy all those icons over from remixicon? Can we not import only the ones we want with something like import hourglass from 'remixicons/hourglass or something like that? This would allow us to treat these icons just like any other dependency, with version control and the ability to get updates easily, among other things. Not a bid deal, but I thought I'd ask.

ktryndchrs commented 3 years ago

Do we really need to copy all those icons over from remixicon? Can we not import only the ones we want with something like import hourglass from 'remixicons/hourglass or something like that? This would allow us to treat these icons just like any other dependency, with version control and the ability to get updates easily, among other things. Not a bid deal, but I thought I'd ask.

@shawninder Regarding this one I think I would need a discussion with you about it

shawninder commented 3 years ago

Si c'est prêt à être mergé, vas-y @ktryndchrs !