search

tjikko-studio / components

Component library for Tjikko Studio apps
0 stars 0 forks source link

Fixes following @shawninder comments #90

Closed ktryndchrs closed 3 years ago

ktryndchrs commented 3 years ago
ktryndchrs commented 3 years ago

👋 Shawn

I made additional changes that should be useful in the future: https://github.com/tjikko-studio/components/pull/90/commits/1c627c0c58f28e95b914776b2a70959867b51a73 https://github.com/tjikko-studio/components/pull/90/commits/6de9a2bd193bf8590ecbbe5c307d82fb69a3c583 https://github.com/tjikko-studio/components/pull/90/commits/971547369b738099ed224f15187f15c4534bca3f

These were useful to to the sitenav. And the updated theme management in storybook should make things way easier with stories & tailwind

Let me know if I can merge (This should be my final version)

PS: Sorry for the hiccups this morning with the merge and revert, I am still learning Github!

ktryndchrs commented 3 years ago

Also @shawninder , this following change now trow me an error on the sitenav.tsx

https://github.com/tjikko-studio/components/pull/90/commits/5ae7e92e8d0e93a487c67631ca0a66703336c8cb

shawninder commented 3 years ago

Also @shawninder , this following change now trow me an error on the sitenav.tsx

5ae7e92

When's the last time you npm i? I just updated some dependencies recently: https://github.com/tjikko-studio/components/commit/821daf62b05ed86d51cdc3bff8dbbf7ca71dfbb5#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519

shawninder commented 3 years ago

If you resolve your Error issue, I think you can merge

ktryndchrs commented 3 years ago

@shawninder

I tried npm i, then to fully reinstall the node modules. But still not working

Terminal => No error Storybook only that weird message:

Cannot read property 'length' of null
TypeError: Cannot read property 'length' of null
    at NavItem (http://localhost:6006/main.iframe.bundle.js:5288:25)
    at renderWithHooks (http://localhost:6006/vendors~main.iframe.bundle.js:122062:18)
    at mountIndeterminateComponent (http://localhost:6006/vendors~main.iframe.bundle.js:124888:13)
    at beginWork (http://localhost:6006/vendors~main.iframe.bundle.js:126126:16)
    at HTMLUnknownElement.callCallback (http://localhost:6006/vendors~main.iframe.bundle.js:111022:14)
    at Object.invokeGuardedCallbackDev (http://localhost:6006/vendors~main.iframe.bundle.js:111071:16)
    at invokeGuardedCallback (http://localhost:6006/vendors~main.iframe.bundle.js:111133:31)
    at beginWork$1 (http://localhost:6006/vendors~main.iframe.bundle.js:131036:7)
    at performUnitOfWork (http://localhost:6006/vendors~main.iframe.bundle.js:129848:12)
    at workLoopSync (http://localhost:6006/vendors~main.iframe.bundle.js:129779:5)

image

ktryndchrs commented 3 years ago

@shawninder : Gotcha!!!

My install does not like the null values here: image