search

tjikko-studio / components

Component library for Tjikko Studio apps
0 stars 0 forks source link

Why not use `Disclosure.Button` and `Disclosure.panel`? #91

Open shawninder opened 3 years ago

shawninder commented 3 years ago

SiteNav uses Disclosure by headlessui, but doesn't use the documented Disclosure.Button and Disclosure.panel.

I'm just curious why? And what are we missing out on, if anything?

shawninder commented 3 years ago

Maybe we can revisit this once we fix the hooks issue

ktryndchrs commented 3 years ago

Personally I simply question the use of disclosure (was not my decision) I will look at this while working on my header-footer branch

shawninder commented 3 years ago

ok, indeed the feature is simple enough, maybe we don't need a library for this. It would be nice to have hooks though ;)