tjim / nevermore

Emacs mail reader based on Notmuch
Other
59 stars 5 forks source link

Strange window splits when viewing messages #1

Closed suvayu closed 10 years ago

suvayu commented 10 years ago

When I read an email from a search (by hitting RET) and then move on to the next email with <down> arrow, nm tries to create another nm-view window instead of updating the present one with the new message. I have attached a screen shot of Emacs when this happens.

nm-bug

Also I would like to say nevermore looks like a great library. I would love it if your usability features could be used from other notmuch modes. For example, I would love to use your incremental search from notmuch-tree (I like the threaded view).

tjim commented 10 years ago

What is <down> bound to? Mine is bound to next-line, and I don't see this behavior. If <down> is bound to something else, how does next-line behave?

suvayu commented 10 years ago

Sorry for the delay, I became preoccupied with more immediate things.

<down>, n, and C-n are all bound to <next-line> and I see the same behaviour with all of them. If it matters, I use notmuch emacs from the git master. Right now I am using commit 6ef676aa.

To test, this is what I do:

$ emacs -Q -l minimal-init.el

Where minimal-init.el is like this (with a few convenience stuff like faces, and variables removed):

(setq debug-on-error t
      debug-on-signal nil
      debug-on-quit nil)

(add-to-list 'load-path "/usr/share/emacs/site-lisp")
(add-to-list 'load-path "~/.emacs.d/lisp")

I then load nevermore with M-x load-library followed by M-x nm RET. Please let me know how if I can provide more information.

tjim commented 10 years ago

Hi. Just tried with that version of notmuch and I don't see the behavior you describe. Maybe an OS/emacs version issue? I am on OS X, 24.3.1. I think I can see how to simplify that code (nm-show-messages), if you can't debug I'll just try a pass at cleaning it up and perhaps that will help.

suvayu commented 10 years ago

Okay.

I'm on Fedora 20, kernel 3.15.6-200.fc20.x86_64, with an Emacs compiled from source from the emacs-24 branch: GNU Emacs 24.3.92.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.10.9) of 2014-07-31 on .

tjim commented 10 years ago

Installed fedora 20 + emacs 24.3.1 from source, don't see this behavior. (Not sure where to get 24.3.92.1) Gotta think it's something weird about your particular configuration...

suvayu commented 10 years ago

My Emacs is from the emacs-24 branch of the emacs git repository: git://git.savannah.gnu.org/emacs.git. I tested again with the absolute minimum of settings, I still see the problem. Of course if you cannot reproduce it, there is no way it can be fixed. If you have any other ideas that I can use to investigate and provide info, I can try that. Otherwise we should let it be, it is not a critical problem for me.

tjim commented 10 years ago

Thanks. I checked out from git and verified the behavior. Emacs has changed the behavior of display-buffer-below-selected. I suspect this is an emacs bug, but in any case I have pushed a workaround, give it a try.

suvayu commented 10 years ago

I just tested, the problem is solved with 3242368b2669! Thank you very much :)