tjko / jpeginfo

jpeginfo - prints information and tests integrity of JPEG/JFIF files
http://www.iki.fi/tjko/projects.html
GNU General Public License v3.0
139 stars 17 forks source link

Append -o flag explicitely in Makefile.in, to fix the build with BSD Make. #36

Closed fcambus closed 9 months ago

fcambus commented 9 months ago

Otherwise hash.o and blocks.o are not generated in the 'sha256' and 'sha512' directories and linking fails.

fcambus commented 9 months ago

Error output when building without the diff using BSD Make:

gcc -g -O2  -DHAVE_CONFIG_H -I.  -c jpeginfo.c
gcc -g -O2  -DHAVE_CONFIG_H -I.  -c jpegmarker.c
gcc -g -O2  -DHAVE_CONFIG_H -I.  -c misc.c
gcc -g -O2  -DHAVE_CONFIG_H -I.  -c md5/md5.c
gcc -g -O2  -DHAVE_CONFIG_H -I.  -c sha256/hash.c
gcc -g -O2  -DHAVE_CONFIG_H -I.  -c sha256/blocks.c
gcc -g -O2  -DHAVE_CONFIG_H -I.  -c sha512/hash.c
gcc -g -O2  -DHAVE_CONFIG_H -I.  -c sha512/blocks.c
gcc -g -O2  -DHAVE_CONFIG_H -I. -o jpeginfo jpeginfo.o jpegmarker.o misc.o   md5/md5.o  sha256/hash.o sha256/blocks.o  sha512/hash.o sha512/blocks.o  -ljpeg
/usr/bin/ld: cannot find md5/md5.o: No such file or directory
/usr/bin/ld: cannot find sha256/hash.o: No such file or directory
/usr/bin/ld: cannot find sha256/blocks.o: No such file or directory
/usr/bin/ld: cannot find sha512/hash.o: No such file or directory
/usr/bin/ld: cannot find sha512/blocks.o: No such file or directory
collect2: error: ld returned 1 exit status
*** Error code 1

Stop.
bmake: stopped in /home/fcambus/jpeginfo
tjko commented 9 months ago

Thanks, merged. As it happens, I just recently was going to test on FreeBSD, but the 'official' KVM/QEMU image didn't seem to have serial console enabled (which seems really odd). So didn't get around to test as was testing from CLI....