tjkohli / nebula-ui-atom

A beautifully minimal, subtly animated, and carefully-designed Atom UI theme with innovative new ideas.
MIT License
43 stars 5 forks source link

Light Version #15

Open stdavis opened 7 years ago

stdavis commented 7 years ago

I have really enjoyed this theme! Thanks for all of your work!

Just suggesting that a light version would be great. I like to switch between light and dark depending on the time of day.

tjkohli commented 7 years ago

I've been considering this idea, but it's interesting you say you like to switch with the time of day. Is sunset/sunrise usually when you switch?

Perhaps we can have an option to auto-switch the theme based on the time.

stdavis commented 7 years ago

Yes, generally I use Light during the daylight and Dark in the evenings. My desk faces some large windows. Auto switching based on sunrise/set would be ideal for me. Time of day would be less useful. Or just a toggle command would be great as well.

tjkohli commented 7 years ago

What's your ideal place for a toggle command? In the Command Palette? Or is the theme configuration fine for you?

stdavis commented 7 years ago

Ideal would be the command pallet. But theme config is what I currently do.

tjkohli commented 7 years ago

How about automatically changing it at Sunrise/Sunset in your current time zone? Or would that not be useful?

stdavis commented 7 years ago

That would be awesome!

tjkohli commented 7 years ago

No promises but I'll try my best.

There's apparently already a plugin that also does that, just FYI: https://atom.io/packages/sunset

stdavis commented 7 years ago

Thanks for the recommendation on the sunset package. That's cool.

tjkohli commented 7 years ago

@stdavis Hey, how is the theme holding up for you? There have been some new updates lately. Do you still want a light theme?

stdavis commented 7 years ago

Hey @tjkohli. To be honest I hadn't looked at it in the while. I find myself rotating between a few different themes for variety. I took a look at your latest updates and it looks great!

Yes, I would still be interested in a light version of this theme. I now use sunset (thanks for the tip!) to switch based on sunset/rise to switch between light and dark themes.

tjkohli commented 7 years ago

@stdavis Which light and dark themes do you use and why? I love hearing user feedback so I can improve Nebula.

stdavis commented 7 years ago

I use one-light for my light theme. I like it because it's simple and the colors pop nicely for JS.

I used to use nebula for my dark theme but recently switch to one-dark. Only because of the new feature of automatically hiding the tab. It's jarring to have the tab hiding and showing every time I make changes to a file then save it. I don't like the fact that the line that I'm typing on moves up and down.

For example: ywetteunii

I wish that there was a config that I could turn this feature off with. Otherwise, I've really enjoyed nebula.

tjkohli commented 7 years ago

Please keep in mind that the up/down animation only happens if you have exactly one tab open. However, I was actually working on a preference for that feature. If you can hang in, it'll be released soon!

Edit: Done! @stdavis

stdavis commented 7 years ago

Just upgraded and unchecked the box. Thanks!