tjkohli / nebula-ui-atom

A beautifully minimal, subtly animated, and carefully-designed Atom UI theme with innovative new ideas.
MIT License
43 stars 5 forks source link

Missing styling for checked items in lists #8

Closed Gert-dev closed 7 years ago

Gert-dev commented 7 years ago

Hello

I just noticed that list views that contain selectable items seem to have no checkmark styling.

An example of a plugin using these is git-plus in its Stage Files view. Here, you can press the return key to select the file to stage. In One Dark and other styles, a checkmark will appear in front of the row in the list. It also appears that other themes reserve space for this checkmark so that the item doesn't jump to the right when the item is selected.

The class hierarchy for this is (from top to bottom)

Thanks in advance

tjkohli commented 7 years ago

Thanks, @Gert-dev! If I understand correctly, this request is related to the git-plus plugin? I'll consider adding support to plugins strictly on a popularity basis.

Gert-dev commented 7 years ago

Thanks! It is indeed related to git-plus, but I believe it originates from the atom-space-pen-views library, which is used by other packages as well (I referenced git-plus because it happens to be using these).

tjkohli commented 7 years ago

Oh look what we have here! 😉

Nebula Git-plus stage files view

Coming soon, in 0.5.0.

tjkohli commented 7 years ago

Fixed! Update to 0.5.0 :)