search

tjmehta / atom-term

shell tab for atom
MIT License
57 stars 15 forks source link

Incompatible with atom 0.121 #24

Open funspectre opened 10 years ago

funspectre commented 10 years ago

Got this error message screenshot from 2014-08-14 13 53 53

yaman commented 10 years ago

yeah I have the same...

faddah commented 10 years ago

ditto this, with the newer Atom Editor 0.123.0 and your Atom Term 0.2.2, and there doesn't show there to be any new update to your package. will there be a fix soon, please?

set up —

iMac w/ intel core i7 @ 2.8 Ghz, 16 GB RAM, Mac OS X 10.9.4 with all current updates, and Atom Editor 0.123.0, your older atom-term package v. 0.2.2 installed.

what it says under incompatible packages tab in the new Atom Editor 0.123.0 at start-up —

Listed below are the incompatible native modules that this package depends on.

pty.js@0.2.4
Error message: Module did not self-register.

could you please advise when there might be a fix for this? thank you.

best,

— faddah wolf portland, oregon, u.s.a. github.com/faddah

tjmehta commented 10 years ago

Thanks guys I'll probably busy for the next 2 weeks but I definitely will fix it after that. Would love a PR if anyone is up for it; the plugin is actually pretty simple.— Typed using my thumbs..

On Sat, Aug 16, 2014 at 10:18 AM, Faddah Wolf notifications@github.com wrote:

ditto this, with the newer Atom Editor 0.123.0 and your Atom Term 0.2.2, and there doesn't show there to be any new update to your package. will there be a fix soon, please? set up — iMac w/ intel core i7 @ 2.8 Ghz, 16 GB RAM, Mac OS X 10.9.4 with all current updates, and Atom Editor 0.123.0, your older atom-term package v. 0.2.2 installed. what it says under incompatible packages tab in the new Atom Editor 0.123.0 at start-up —

Listed below are the incompatible native modules that this package depends on.
pty.js@0.2.4
Error message: Module did not self-register.

could you please advise when there might be a fix for this? thank you. best, — faddah wolf portland, oregon, u.s.a.

github.com/faddah

Reply to this email directly or view it on GitHub: https://github.com/tjmehta/atom-term/issues/24#issuecomment-52400129

faddah commented 10 years ago

hi @tjmehta ,

thank you for responding and i understand your being busy right now. i would gladly do a PR for you, except for one thing — the error making your current package incompatible is, again:

Listed below are the incompatible native modules that this package depends on.

pty.js@0.2.4
Error message: Module did not self-register.

...so in the new Atom Editor 0.123.0 - what does it take to self-register the module? is it the pty.js module that needs to self-register, or the atom-term package in general? please advise.

best,

— faddah portland, oregon, u.s.a. github.com/faddah

f commented 10 years ago

This commit will fix it: https://github.com/webBoxio/atom-term2/commit/f53bcad833858961dd4086e266652a501d26a08c