tjohansen14 / diskscrub

Automatically exported from code.google.com/p/diskscrub
GNU General Public License v2.0
0 stars 0 forks source link

2.6.0 failures on OS X 10.8.5 #31

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
1) build problem

scrub.c: In function ‘scrub_resfork’:
scrub.c:704: error: ‘const struct opt_struct’ has no member named 
‘bufsize’
make[1]: *** [scrub.o] Error 1
make: *** [all-recursive] Error 1

-- scrub.c.orig 2014-08-21 21:18:52.000000000 -0700
+++ scrub.c 2014-08-21 21:19:07.000000000 -0700
@@ -701,7 +701,7 @@
         printf("%s: padding %s with %d bytes to fill last fs block\n", 
                         prog, rpath, (int)(rsize - rsb.st_size)); 
     }
-    scrub(rpath, rsize, opt->seq, opt->bufsize, false, false, false);
+    scrub(rpath, rsize, opt->seq, opt->blocksize, false, false, false);
 }
 #endif

2) unit test probs

t01 takes about a minute (but passes)

t15 fails od indentation is different on osx
t16 fails od indentation is different on osx
t17 fails mktemp prints usage message
t22 fails mktemp prints usage message

Original issue reported on code.google.com by garlick....@gmail.com on 22 Aug 2014 at 4:22

GoogleCodeExporter commented 8 years ago
Also, t16 --dry-run produces 'scrub res fork' output on OS X

Original comment by garlick....@gmail.com on 22 Aug 2014 at 5:37

GoogleCodeExporter commented 8 years ago
Fixes committed for scrub-2.6.1

commit 7749da6ec6586656ac94179beccdfedf1b80dbb6
Author: Jim Garlick <garlick.jim@gmail.com>
Date:   Fri Aug 22 10:41:32 2014 -0700

    issue 31: OS X t16 test failure

    Eliminate 'res fork' --dry-run output from comparision in t16.

commit 293392be4d694581bd5afdd0a196ba2d4ec993c7
Author: Jim Garlick <garlick.jim@gmail.com>
Date:   Fri Aug 22 10:15:54 2014 -0700

    issue 31: OS X test failures

    mktemp(1) TEMPLATE arg is required on OS X.

    Use diff -b to ignore different whitespace in od output on OS X.

commit 025aeefa8b3af349f220f9a1716970b6f920ef48
Author: Jim Garlick <garlick.jim@gmail.com>
Date:   Fri Aug 22 10:10:35 2014 -0700

    issue 31: OS X build failure

Original comment by garlick....@gmail.com on 22 Aug 2014 at 5:43

GoogleCodeExporter commented 8 years ago
Long time for t01 was not addressed.

Original comment by garlick....@gmail.com on 22 Aug 2014 at 5:43