search

tjohnson1106 / saga-beta-V1

saga-stack-merged
1 stars 0 forks source link

Adding GraphQL Fragments is Breaking App #13

Closed tjohnson1106 closed 6 years ago

tjohnson1106 commented 6 years ago

Added GraphQL fragment queries for all data fetches except favorites and for creating new content and the data added subscription. It breaks the app, no stack trace, no info in the debugger the simulator simply shows a red screen. After a day on this I am adding the old queries and putting this on hold. (there was no task on the board for adding fragments)

tjohnson1106 commented 6 years ago

Re-attempted to implement fragments using the Feedcard components again; however, attempted to fragment user data gql query as opposed to the query that grabs all initial data. Breakage is the same. I should look over the optimistic response and the promises again.

Screenshot below shows home screen that is all red no stack trace. Is the same on physical device and the emulator. Terminal shows mock data being retrieved.

Saga-Beta-V1_Home_Screen_After_Fragment_Implementation.png

Will create a git flow bugfix branch and leave open.

Though there are code reduction and performance benefits, should this wait to pre-production re-factor to implement. Is there a case for not implementing at all?

tjohnson1106 commented 6 years ago

Fragment work via version Beta4. Closing issue.