search

tjohnson1106 / saga

V1
0 stars 0 forks source link

Implement Styled Components #9

Closed tjohnson1106 closed 6 years ago

tjohnson1106 commented 6 years ago

Kill stylesheet code and implement styled components

tjohnson1106 commented 6 years ago

I am moving this from "done" to review. I think styled components are the best styling solution available by far; however they do dramatically alter the code structure and it's too early to cement this as a production feature. At this point I am 90%

tjohnson1106 commented 6 years ago

Ultimately I am still committed to using styled-components, I believe it is the best solution; however I do have some performance concerns. The developers there said they have vastly improved on the performance issues as it pertains to react-native. I think the best solution is to code the UI using flex and create a shadow UI using styled components as I go along. Ultimately there will need to be performance testing. Moving to backlog.

tjohnson1106 commented 6 years ago

Given the current stack and the leaner, more efficient code base I believe that we will not use styled-components. One the major benefits was semantic code base organization and that has improved, further research suggests that performance issues are a real possibility and the risk does not seem to outweigh the benefits, closing issue.