search

tjosepo / ror2-editor

A web app that allows you to fully customize your Risk of Rain 2 savefile.
https://riskofrain2-save-editor.web.app/
44 stars 9 forks source link

Deploy failed action on PR from a forked repository #19

Open marcalexiei opened 2 weeks ago

marcalexiei commented 2 weeks ago

I'm opening an issue to avoid posting off topic content on #17 and because I have the same error on #18

Regarding https://github.com/tjosepo/ror2-editor/pull/17#pullrequestreview-2273980836

Deploy to Firebase Hosting on PR workflow failed with an error:

Input required and not supplied: firebaseServiceAccount

I think the error cause is that Github does not provide secrets when a PR is opened from a forked repository:

If you go on https://github.com/OWNER/REPO/settings/secrets/actions On the second paragraph it says:

Anyone with collaborator access to this repository can use these secrets and variables for actions. They are not passed to workflows that are triggered by a pull request from a fork.

There is also a opened issue about this problem on Firebase action-hosting-deploy repository: https://github.com/FirebaseExtended/action-hosting-deploy/issues/337

Right now I'm unable to find an alternative solution 😫

marcalexiei commented 2 weeks ago

Maybe restore the check removed in #14 could be a temporary workaround. At least the deploy is available if the PR is coming from this repo 😅