tjscience / RoboSharp

RoboSharp is a .NET wrapper for the awesome Robocopy windows application.
MIT License
216 stars 67 forks source link

Net40 Support #136

Closed RFBomb closed 2 years ago

RFBomb commented 2 years ago

Formal request to drop Net40 from target frameworks.

Net40 has been deprecated and has not received security updates since 2016. It also prevents use of Async methods, along with await.

it would also remove the need for the #if net40 statements, since nearly all of the other targets (save for edge cases easily worked around) have support for nearly all the same methods available.

My reason for this request is RoboQueue. During my testing, what I’ve been seeing is that occasionally RoboCommands get stuck in a ‘waiting to run’ state while the RoboQueue method is in its sleep loop, meaning it is at a standstill that will Never complete. Using await Task.delay Frees the thread up to do work, such as starting the robocopy start command.

What I propose:

PCAssistSoftware commented 2 years ago

All of that makes perfect sense to me, and I fully agree, But let's see what @tjscience has to say on the matter first :)

RFBomb commented 2 years ago

That’s why I made it a new issue! (and just in case any Net40 projects around still exist that are using this have a reference thread to look at if they pull an incompatible release)

RFBomb commented 2 years ago

Net40 branch created.