search

tjsnell / vdiff

Camel Release Package Version Diffs
Apache License 2.0
2 stars 0 forks source link

accept the version ranges properties #2

Closed elakito closed 9 years ago

elakito commented 9 years ago

Hi Tracy, I added the handling of the range suffix. Both cxf and camel use either name.version.range or name-version-range to define the corresponding osgi version ranges. Currently, these properties are not included in the list. I modified the regex so that they are also picked up.

Could you include this change? Thanks. regards, aki

tjsnell commented 9 years ago

Yep. I’ll merge it in. Making a bunch more changes. I have Branch and Tag support now local. Just need to clean it up.

Thanks

On Aug 12, 2014, at 9:40 AM, elakito notifications@github.com wrote:

Hi Tracy, I added the handling of the range suffix. Both cxf and camel use either name.version.range or name-version-range to define the corresponding osgi version ranges. Currently, these properties are not included in the list. I modified the regex so that they are also picked up.

Could you include this change? Thanks. regards, aki

You can merge this Pull Request by running

git pull https://github.com/elakito/vdiff master Or view, comment on, or merge it at:

https://github.com/tjsnell/vdiff/pull/2

Commit Summary

accept the version ranges properties File Changes

M src/main/java/cc/notsoclever/tools/Versions.java (9) M src/test/java/cc/notsoclever/tools/VersionsTest.java (12) Patch Links:

https://github.com/tjsnell/vdiff/pull/2.patch https://github.com/tjsnell/vdiff/pull/2.diff — Reply to this email directly or view it on GitHub.

tjsnell commented 9 years ago

Merged in your patch and deployed.

Also note that the UI handles tags properly now so the server side doesn’t have to muck with them. I adjusted the tests to reflect that.

You can now diff tags or branches. Pondering if it makes sense to be able to diff a tag against a branch. Only thing needed to support that is a UI change.

Thanks again!