search

tjsnell / vdiff

Camel Release Package Version Diffs
Apache License 2.0
2 stars 0 forks source link

vdiff under a custom path not working anymore #3

Open elakito opened 9 years ago

elakito commented 9 years ago

Hi Tracy, it looks like the resource references and path rewriting in the current version assumes the app to be deployed at the root. So the instruction at README is not working, as it uses the path parameter to deploy the app at path version-diff.

You can run within your web container or alternatively run it standalone using jetty-runner

java -jar target/dependency/jetty-runner.jar --path version-diff --port 8181 target/*.war

Then, using your browser to open

http://localhost:8181/version-diff/

It looks like the change (or this limitation) came during the previous marge.

Will you be looking into this? It's not urgent, though.

regards, aki

tjsnell commented 9 years ago

Yeah. I ran into issues not having it run at root that I need to explore. The README needs updating. It’s on my list. SimpleServlet that adds in the URL support is what pushed that root requirement and I just haven’t had time to sit and think about it :)

Last night I ran into githubs 60 api calls/hr limit. Didn’t realize it existed.

On Aug 18, 2014, at 6:27 AM, elakito notifications@github.com wrote:

Hi Tracy, it looks like the resource references and path rewriting in the current version assumes the app to be deployed at the root. So the instruction at README is not working, as it uses the path parameter to deploy the app at path version-diff.

You can run within your web container or alternatively run it standalone using jetty-runner

java -jar target/dependency/jetty-runner.jar --path version-diff --port 8181 target/*.war

Then, using your browser to open

http://localhost:8181/version-diff/

It looks like the change (or this limitation) came during the previous marge.

Will you be looking into this? It's not urgent, though.

regards, aki

— Reply to this email directly or view it on GitHub.