tjtanjin / react-chatbotify

A modern React library for creating a flexible and extensible chatbot.
https://react-chatbotify.tjtanjin.com/
MIT License
103 stars 49 forks source link

truncate load history button text #47

Closed I-Vishal-Kumar closed 2 months ago

I-Vishal-Kumar commented 2 months ago

Description

Regarding your issue #46 ( [Bug] Fix load & previous chat history text overflow ) Long text's were overflowing the button which makes the UI look bad.

Closes #46

What change does this PR introduce?

The PR includes changes in the files

  1. ChatHistoryButton.tsx
  2. ChatHistoryButton.css

Please select the relevant option(s).

What is the proposed approach?

The approach I end up with is by not allowing the text to wrap and by making the text overflow to ellipses.

Checklist:

I-Vishal-Kumar commented 2 months ago

Hey @I-Vishal-Kumar, thank you for taking up this issue. The approach is alright but there are quite a number of formatting changes from tabs to whitespaces. Could you help standardize all of these to tabs? Thanks!

Shure I will do that.

I-Vishal-Kumar commented 2 months ago

I have fixed the indentation problem please review it again.

tjtanjin commented 2 months ago

Hey @I-Vishal-Kumar! If you view the file changes, the issue is still there 😰 There also seems to be repetition now for the rcb-view-history-button class. Would you like to take a look at it again? Thanks!

I-Vishal-Kumar commented 2 months ago

I have created a new branch "truncate-history-button" with commit Truncate history button #50 this resolves all your concern's

tjtanjin commented 2 months ago

Closed in favor of #50