tjtanjin / react-chatbotify

A modern React library for creating a flexible and extensible chatbot.
https://react-chatbotify.tjtanjin.com/
MIT License
103 stars 49 forks source link

enh: replace any type by options type #52

Closed HaecheonLee closed 2 months ago

HaecheonLee commented 2 months ago

Description

This includes to replace any type with the existing type. Also, it adds additional validation by checking mergedValue in the line 224 in the component.

What change does this PR introduce?

Please select the relevant option(s).

What is the proposed approach?

Please give a short overview/explanation on the approach taken to resolve the issue(s).

Checklist:

tjtanjin commented 2 months ago

Hey @HaecheonLee, thanks for this PR. There's actually a logic change for this portion in working-branch-2.0.0. Do you mind making the changes over in that branch instead? For your reference: https://github.com/tjtanjin/react-chatbotify/blob/working-branch-2.0.0/src/services/BotOptionsService.tsx

HaecheonLee commented 2 months ago

Sure, I will take a look at the branch.

HaecheonLee commented 2 months ago

@tjtanjin Hi, it would be nice to have #53 merged into the branch first, and after it's merged, I will push a commit and open this PR again.